Making a Pull Request (PR)

Owned by Shay Naveh (Deactivated)
Dec 30, 2019
2 min read

When your code is done

  • meaning you conducted thorough testing on a real device, it is time for the

pull request.
For more details about pull requests requirements, see Code Review / Pull Requests
To create a pull request. you use Bitbucket.
Your pull request should be from the branch you're currently working on and into staging. Here's how to do this in Sourcetree:

  1. Go to your IKP in JIRA, and click on the 'branches' link
    In the popup, click on your branch. Usually, there is only one to choose from.

 

2. On the branch page, select the 'Create pull request'

 

3. Finally, create the PR. Make sure to target the correct destination branch, add a reviewer, and always select 'Close <branch_name> after the pull request is merged'

 

Once the pull request is approved, someone else will do the final "merge" into staging.
The code will then be tested automatically.

Bam, you're code has made it to the world.